Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redfishpower: remove --hostsfile option #123

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Feb 6, 2024

Problem: The redfishpower --hostsfile option is oddly included in the project as an option. The suspicion is it was copy and paste from another project. The short option for the option is not configured, but the long option is. It is not documented in --help output, but is oddly documented in the manpage.

Drop the option.


I just saw this and was "uuhhhh why is this here"?

Problem: The redfishpower --hostsfile option is oddly included in the
project as an option.  The suspicion is it was copy and paste from
another project.  The short option for the option is not configured,
but the long option is.  It is not documented in --help output, but is
oddly documented in the manpage.

Drop the option.
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit c265416 into chaos:master Feb 6, 2024
8 checks passed
@chu11 chu11 deleted the redfishpower_hostsfile branch February 6, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants